[x] checked the commit log to see if my issue has been resolved since my server was last updated
Client Version (type /ver in game) :
30191227_0
Source Branch (master/stable) :
master
Additional Information (Steps to reproduce/Expected behavior) :
In retail, the check for which races magical pattern time is checked for the goblins message for where to go and for actually obtaining the magical pattern key item, but if you already possess the key item you can turn it in at any time.
On Darkstar, you can only turn in the pattern during your time. So if you get the pattern but it switches over to another race before you get back to town, you are stuck waiting.
It also looks like we're just trusting the option code in the onEventFinish. We should always re-verify that the player meets the requirements there to prevent the player from just injecting packets to get what they want out of the cs event.
I have:
Client Version (type
/verin game) : 30191227_0Source Branch (master/stable) : master
Additional Information (Steps to reproduce/Expected behavior) : In retail, the check for which races magical pattern time is checked for the goblins message for where to go and for actually obtaining the magical pattern key item, but if you already possess the key item you can turn it in at any time.
On Darkstar, you can only turn in the pattern during your time. So if you get the pattern but it switches over to another race before you get back to town, you are stuck waiting.
It also looks like we're just trusting the option code in the onEventFinish. We should always re-verify that the player meets the requirements there to prevent the player from just injecting packets to get what they want out of the cs event.