search

Darnoman / Godot-GlobalInput-Addon

MIT License
13 stars 3 forks source link

SharpHook Issue #5

Closed MudkipWorld closed 1 month ago

MudkipWorld commented 2 months ago

I really love the addon, it has helped me so much with making my Desktop Pet widget, but the addon seems windows exclusive only, which is fine, by all means.

A quick question came to mind, wouldn't using a library like https://github.com/TolikPylypchuk/SharpHook help make it easier to make the addon cross platform and help add the listed missing features?

I sadly don't have much C# experience, but I still felt like mentioning the library could help you at some point if you were wanted to make the addon not strictly for windows only!

Darnoman commented 2 months ago

I do have a branch for sharphook.. if you want to take a look. Lmk if you can see it. I don't have a Linux or a Mac/IOS so im unable to test sharphook to see if it works on those platforms. It should work on windows though. If you'd like to test it out and let me know if you run into issue that'd be a great help.

MudkipWorld commented 2 months ago

Ah, I see it now, didn't notice it earlier. Sorry for the confusion ^^; Thanks for letting me know btw!

MudkipWorld commented 2 months ago

Hey, sorry for reopening the issue, but I am having a bit of a problem with the SharpHook addon ^^; In my app, you can have "States" that you can rebind keys to. However, this seems to not work with the addon for some reason.

issue

rebinding code : IssueScreenshot1

the part where it detects the input :

IssueScreenshot2

Darnoman commented 2 months ago

Okay I know what the issue is. So when I created this pluggin, I assumed that the inputs were gunna be static. And so what's happening is that when you put in a new keybind, it doesn't update the GlobalInput's internal InputMap called ActionDictionary. This is what's causing the null returns. I've solved it on my end, through some janky code just need to think of a way to make it neater.

Darnoman commented 2 months ago

(GlobalInputCSharp.cs line 375) image

(GlobalInputCSharp.cs line ~400-405) image

those should fix ur issues for now... until i find a more permanent solution

https://github.com/user-attachments/assets/e7df82de-21aa-40dd-ab34-0397b7e2972d

MudkipWorld commented 2 months ago

Thanks for your answer, I guess the issue should still be open since it isn't 100% fixed?

Darnoman commented 2 months ago

alright I pushed an update. Let me know if you run into other issues. (also do you think I should just make sharphook the main branch?)

MudkipWorld commented 1 month ago

Thanks for the quick fix, for the main branch thing, it is up to you. I say if you feel like it could give wider support and ease of use, go for it!