Great work on implementing the requirements. Your project is complete. :blush:
There is nothing else to say about your project. :+1:
Highlights :1st_place_medal:
:heavy_check_mark: Descriptive PR Summary
:heavy_check_mark: Descriptive PR Title
:heavy_check_mark: Descriptive Readme
:heavy_check_mark: Following the GitFlow
:heavy_check_mark: Following Linters
✔️ Following the Requirements
Optional
[ ] you can collect your code inside one loop because you are repeated the for loop twice
for (let i = 0; i < dots.length; i += 1) { // Your code }
[ ] You did well coming up with this great solution, you can replace your standard for loop with foreach
[ ] Please check comment below
[ ] Activate your reset button that is marked by the green color below
[ ] Add padding or margin to your Todo task content to be in the same line with the check and trash button
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Status: Approved :green_circle:
Hey @Daron976 :wave:
Great work on implementing the requirements. Your project is complete. :blush: There is nothing else to say about your project. :+1:
Highlights :1st_place_medal:
:heavy_check_mark: Descriptive PR Summary :heavy_check_mark: Descriptive PR Title :heavy_check_mark: Descriptive Readme :heavy_check_mark: Following the GitFlow :heavy_check_mark: Following Linters ✔️ Following the Requirements
Optional
for (let i = 0; i < dots.length; i += 1) { // Your code }for loopwithforeachcheckandtrashbuttonAll the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.