Timestamps should be `i64` and not `i32` - Githubissues

DarrenBaldwin07 / clerk-rs

An unofficial Rust SDK for Clerk.dev

https://crates.io/crates/clerk-rs

MIT License

58 stars 23 forks source link

Timestamps should be `i64` and not `i32` #23

Closed TmLev closed 5 months ago

TmLev commented 6 months ago

Based on the documentation, Clerk seems to use i64 for timestamps.

After briefly reviewing the codebase, I've identified several instances of i32 timestamps:

In email address verification: https://github.com/DarrenBaldwin07/clerk-rs/blob/b47c950a6f7b689a57d6508393b7a31b34246a1f/src/models/email_address_verification.rs#L20
In the admin model, where it's also incorrectly wrapped in Option twice: https://github.com/DarrenBaldwin07/clerk-rs/blob/b47c950a6f7b689a57d6508393b7a31b34246a1f/src/models/admin.rs#L30
In sign up: https://github.com/DarrenBaldwin07/clerk-rs/blob/b47c950a6f7b689a57d6508393b7a31b34246a1f/src/models/sign_up.rs#L101

DarrenBaldwin07 commented 5 months ago

Great callout - PRs are welcome but Im also going to update to the latest Clerk API spec so this should fix it

sjmiller609 commented 5 months ago

Closed by https://github.com/DarrenBaldwin07/clerk-rs/pull/31/files