search

DarrenOfficial / dpaste

The Django project driving dpaste.org
https://dpaste.org
MIT License
541 stars 124 forks source link

CORS Header (Access-Control-Allow-Origin) is missing again #242

Closed Steve-xmh closed 11 months ago

Steve-xmh commented 11 months ago

Description

First of all, thank you for this free and available pastebins service!

I've noticed that #225 added header Access-Control-Allow-Origin: * that I can use for uploading some temporary data via javascript, but the header is missing now without reason:

image

I know it will be a cash-burning work to deliver this free service. So if it's intentional I'll close this issue.

Steps to reproduce

const rawUrl = await fetch("https://dpaste.org/api/", {
    method: "POST",
    mode: "cors",
    headers: {
        "Content-Type": "application/x-www-form-urlencoded"
    },
    body: "format=url&expires=3600&filename=somedata.txt&content=testing"
});
DarrenOfficial commented 11 months ago

Hello, Yes, I've temporarily removed the CORS due to the way I implemented it. Due to how many request dpaste was getting, I was getting billed by Cloudflare per that extra request

cors

I must admit the way I add CORS @ Cloudflare edge was a bit stupid. I've pushed the changes I was planning on doing since that request was made. Access-Control-Allow-Origin is enabled again now, and the way I implemented it is way better, because I added it in the application layer :D

New Config

Steve-xmh commented 11 months ago

It's backed to work now. Thank you so much!