search

Darrken / RockSmithCDLCRenamer

Renames Rocksmith 2014 CDLC files to match the Custom Song Creator output format: Artist_Song-Name_Version
6 stars 2 forks source link

General feedback & issue with "rs1compatibilitydlc_p.psarc" #1

Closed jnettels closed 10 years ago

jnettels commented 10 years ago

Hi there, I don't know if you saw my post in the Customsforge forums... but I'm posting it here again, since it contains an issue as well :-)

Wow, this tool is a great idea! But I feel like it is kind of hidden here in this forum... maybe you should rather post it in the Toolkit Forum since it is directly connected to the use of the Toolkit.

Now all the official DLC are sorted correctly as well, nice :-)

One thing is that you could use the "version" information from inside the psarc to add it to the file name (and make that v1_0 if no version entry exists, e.g. for official songs or some CDLC)

Maybe the creator of the DDC can give you a hint on how to find out whether mulitple levels of difficulty exist in the DLC :-)

And I've spotted one problem:

Old Filename: rs1compatibilitydlc_p.psarc New Filename: T-Rex_20th-Century-Boy_p.psarc Artist: T.-Rex Song: 20th-Century-Boy

This file should definitely be ignored by your program!

Darrken commented 10 years ago

Ah, I haven't been back to check the thread on Customsforge for a while (you're right, it was kind of buried and ignored, so I didn't think I was getting any more responses).

Thank you for the feedback! I did look into using the version info... in a lot of cases I don't think the authors are actually updating the version info within the file. Most authors just seem to change the filename, so if I relied on the metadata it was ending up being "v1" or empty 9/10 times. The Song Creator doesn't seem to use it either when generating the output filename, so I just went with parsing the existing filename for version.

I wonder what other compatibility/other packs there are, if any, besides the rs1compatibility pack. I totally missed those! They still seem to work despite the rename, but you're right, those aren't files that should be getting renamed. I'll have to see if I can find a list or check the directory on a fresh install.

Thanks again for the input! Ken

On Mon, Sep 22, 2014 at 2:21 PM, AzraelDD notifications@github.com wrote:

Hi there, I don't know if you saw my post in the Customsforge forums... but I'm posting it here again, since it contains an issue as well :-)

Wow, this tool is a great idea! But I feel like it is kind of hidden here in this forum... maybe you should rather post it in the Toolkit Forum since it is directly connected to the use of the Toolkit.

Now all the official DLC are sorted correctly as well, nice :-)

One thing is that you could use the "version" information from inside the psarc to add it to the file name (and make that v1_0 if no version entry exists, e.g. for official songs or some CDLC)

Maybe the creator of the DDC can give you a hint on how to find out whether mulitple levels of difficulty exist in the DLC :-)

And I've spotted one problem:

Old Filename: rs1compatibilitydlc_p.psarc New Filename: T-Rex_20th-Century-Boy_p.psarc Artist: T.-Rex Song: 20th-Century-Boy

This file should definitely be ignored by your program!

— Reply to this email directly or view it on GitHub https://github.com/Darrken/RockSmithDLCRenamer/issues/1.

jnettels commented 10 years ago

"The Song Creator doesn't seem to use it either when generating the output filename" I have to disagree with you there ;-) What you write into the "Version" field in the Toolkit UI is indeed used for the filename AND stored within the psarc. You might be right, though, about the fact that some users do not use this function (which is kind of sad, and I think important for the upcoming update of the search engine and download manager)

If you decide to include options on how to name the output files (like TomSawyer suggested), you could add the option to use the version info :-)

In the "DLC" folder, rs1compatibility is the only pack you have to exclude! All other packages (for official songs, lessons and so on) are stored in the main folder.

I sugguest asking a mod to move your thread. I often read people complaining about the filename issue, so there definitly is more demand for your program than it may currently seem ;-)

Darrken commented 10 years ago

Huh, you're right about the song creator. I've updated so many with it and always seem to get "Artist_Songname_v" at the prompt that I assumed it didn't put it in. It's either been updated or I predominantly was editing songs that didn't have version info (probably the latter). :)

That is a good idea about offering it as an option. When I get some time to update it I will definitely attempt that.

I think there might be two rs1compatibility files. A while ago I moved all the mac files into a backup folder so they didn't clutter my DLC folder, and in there I found: rs1compatibilitydisc and rs1compatibilitydlc. Both files had been renamed in my pc DLC folder. :\ I need to get in a fix for that asap.

Thanks again for your valuable input!

On Tue, Sep 23, 2014 at 6:00 AM, AzraelDD notifications@github.com wrote:

"The Song Creator doesn't seem to use it either when generating the output filename" I have to disagree with you there ;-) What you write into the "Version" field in the Toolkit UI is indeed used for the filename AND stored within the psarc. You might be right, though, about the fact that some users do not use this function (which is kind of sad, and I think important for the upcoming update of the search engine and download manager)

If you decide to include options on how to name the output files (like TomSawyer suggested), you could add the option to use the version info :-)

In the "DLC" folder, rs1compatibility is the only pack you have to exclude! All other packages (for official songs, lessons and so on) are stored in the main folder.

I sugguest asking a mod to move your thread. I often read people complaining about the filename issue, so there definitly is more demand for your program than it may currently seem ;-)

— Reply to this email directly or view it on GitHub https://github.com/Darrken/RockSmithDLCRenamer/issues/1#issuecomment-56509122 .

jnettels commented 10 years ago

Yeah, I just realized one of my customs was lacking the version info as well, while I could swear that I always fill out that field. Maybe it only works when you are sticking to the correct format "1.0", or they did indeed change something...

Do you know the GP5 converter? http://www.rocksmithtotab.de/ There is a screenshot on that side. It would be great if you could offer the same file name template approach, like: {artist sort} - {title} - {version} - {tabber} - {album} - {year} ...

Darrken commented 10 years ago

That's actually a really good idea. If people really wanted more than artist/songname they could do it. I like it. I'll could try to do that next.

Today I've been messing around with a simple optional options.txt file that a user could customize, based on your input and the other guy that

commented in the thread. Here's what it looks like:

Artist-Song-Separator: "_" Space-Character: "-" Use-Metadata-Version: false Use-Metadata-DD: false

The Artist-Song-Separator sets the character between Artist - Song -

Version - DD

ex: Cure_Burn_v1_DD_p.psarc

The Space-Character sets the character used for spaces in an Artist name

or Song title

ex: Arctic-Monkeys_Do-I-Wanna-Know_v1_p.psarc

Use-Metadata-Version:

If true, this will get the version number from the file metadata if it

exists

(many song authors at this time do not fill in the version metadata, so

you may end up with a lot of "v1" in your filenames)

If false, the renamer will attempt to get the version in the existing

filename

Use-Metadata-DD:

If true, the renamer will attempt to determine whether the song supports

Dynamic Difficulty from file metadata. May not be 100% accurate.

If false, the renamer will just look for "_DD" in the existing filename

On Tue, Sep 23, 2014 at 3:11 PM, AzraelDD notifications@github.com wrote:

Yeah, I just realized one of my customs was lacking the version info as well, while I could swear that I always fill out that field. Maybe it only works when you are sticking to the correct format "1.0", or they did indeed change something...

Do you know the GP5 converter? http://www.rocksmithtotab.de/ There is a screenshot on that side. It would be great if you could offer the same file name template approach, like: {artist sort} - {title} - {version} - {tabber} - {album} - {year} ...

— Reply to this email directly or view it on GitHub https://github.com/Darrken/RockSmithDLCRenamer/issues/1#issuecomment-56590524 .