search

DarryllRobinson / jammming

0 stars 0 forks source link

Summary #5

Open farishkash opened 6 years ago

farishkash commented 6 years ago

I wish I had an opportunity to talk to you.

I had a couple learners who are in a similar situation use Dreezer instead since it is similar to Spotify.

Overall needs improvement.

This is not a normal review due to your situation.

The search function in the search bar file was treated as a variable instead of a function, where typically term would be pass through as an argument.

I mention state mutation, this should always be avoided. I had another project that did something similar and what was happening was they were removing a track from the playList after removing that same track from the playList. It created a loop where two tracks were removed for each one removed and breaking the project directly as a result of this.

I was trying to deconstruct your hard-coded responses but they weren't being treated as JSON and causing additional errors. This made part of the review difficult.

Unfortunately, due to these circumstances, the project isn't functioning properly.

DarryllRobinson commented 6 years ago

Thank you for your comments, all of which are fair and accurate. Unfortunately, I found the step up from the regular projects to this one a bit more than I could handle, especially as I couldn't use the Spotify API as intended. Ironically, Spotify actually launched in South Africa yesterday.

I plan to use your feedback and the rest of the course to start creating my own content management system. There will be lots of Googling in my future to get things to work properly!

Thanks again

Darryll

farishkash commented 6 years ago

Just for your information, you will need a backend for this if you plan to save any data.

DarryllRobinson commented 6 years ago

Good morning

Thank you for the tip. I actually just finished the API course on Codecademy which went decidedly better than this last project.

Do you know who I could contact to offer feedback for the BWA course? There are no sour grapes at all, I just want to offer some thoughts.

farishkash commented 6 years ago

When you submit the project, there should be a feedback option there. If you don't see it, you can use this link here and let them know you would like to offer feedback.

https://help.codecademy.com/hc/en-us/requests/new

Interesting, about the build api course. I felt it was more difficult than this one, but I haven't done the final project yet.