Convert to Swift 5 - Githubissues

DarshanGowda0 / GeoFlutterFire

:fire:GeoFlutterFire:fire: is an open-source library that allows you to store and query firestore documents based on their geographic location.

https://youtu.be/MYHVyl-juUk

MIT License

305 stars 261 forks source link

Convert to Swift 5 #101

Closed awhitford closed 3 years ago

awhitford commented 4 years ago

XCode gives me a Buildtime Warning saying that geoflutterfire.framework may be converted to Swift 5.

Any chance that this can be upgraded so that this warning goes away?

DarshanGowda0 commented 4 years ago

Hi @awhitford! Is this applicable to this plugin code? or does this have to do with the firestore plugin?

awhitford commented 4 years ago

I'm pretty sure it is referring to this project: https://github.com/DarshanGowda0/GeoFlutterFire/blob/7f4c29db3072b2a56b27e582038392eea2deb8b2/ios/geoflutterfire.podspec#L8

Having said that, perhaps the best approach would be to purge the Swift code (and Kotlin code for Android) altogether because there is nothing native going on here. Since the code is all Dart, this doesn't need android & ios specific code. This change would ultimately be better because it is automatically multi-platform.

awhitford commented 4 years ago

When you created the project, you had a choice to create a plugin or a package, and you chose plugin, but you really needed a package:

package - Generate a shareable Flutter project containing modular Dart code.
plugin - Generate a shareable Flutter project containing an API in Dart code with a platform-specific implementation for Android, for iOS code, or for both.

DarshanGowda0 commented 4 years ago

Yep, this makes sense. I'll see what I can do