Dart-Code / Dart-Code

Dart and Flutter support for VS Code
https://dartcode.org/
MIT License
1.46k stars 295 forks source link

Debug Console doesn't add clickable links for stdout output when using new Dart SDK debug adapters #5072

Closed DanTup closed 2 weeks ago

DanTup commented 1 month ago

Splitting from https://github.com/Dart-Code/Dart-Code/issues/4711 since there are two sets of work here - one to support in the base adapters, and one to update the Flutter adapter.

Here's an example of the issue in Dart:

import 'dart:io';

void main() {
  print('stdout');
  stdout.write(StackTrace.current);
  print('stderr');
  stderr.write(StackTrace.current);
}

image

In the old debug adapters it looks like:

image

DanTup commented 1 month ago

With https://dart-review.googlesource.com/c/sdk/+/362804:

image

DanTup commented 2 weeks ago

The fix for this has landed. In the latest bleeding edge SDKs (v3.5), it looks like this:

image

We no longer try to strip the filename out of the printed line (it sometimes looked odd if it wasn't the end of the line), but the white links do appear on the right side now.