search

Dart-Code / Dart-Code

Dart and Flutter support for VS Code
https://dartcode.org/
MIT License
1.46k stars 295 forks source link

Remove use of page= query param for DevTools embeddings #5098

Closed kenzieschmoll closed 3 weeks ago

kenzieschmoll commented 3 weeks ago

There is a TODO in the DevTools codebase to stop using the page query parameter from IDEs.

@DanTup can you confirm that we do not use this from VS Code? If we do not use this, this issue can be closed. If we do, we should migrate to use the path based routing, which has been the DevTools standard for a number of years now.

DanTup commented 3 weeks ago

Correct, we stopped using page= in https://github.com/Dart-Code/Dart-Code/issues/3800 for new SDKs.

You might need to update the DevTools server's implementation of launchDevTools along with removing it though (and any other places in Dart/Flutter that might be building these URLs):

https://github.com/dart-lang/sdk/blob/6bec589f00d1009199912eceb327294c72934b7b/pkg/dds/lib/devtools_server.dart#L714