Dartanlla / OWS

Open World Server system
MIT License
362 stars 339 forks source link

.Net 8 testing - OWS seens to be running fine #127

Closed miketoupin closed 1 year ago

miketoupin commented 1 year ago

This branch needs to be tested thoroughly before a PR into Main.

SloppyShovel commented 1 year ago

Will have to wait until .Net 8 becomes a release version merging to Release Candidates is not a good idea.

miketoupin commented 1 year ago

Completely agree,

This branch is only for testing purpose. Like I said to Dart, it is only to confirm there is no incompatibilities before moving to the next LTS, which will happens very soon.

On Tue, Oct 3, 2023, 10:54 AM Kevin Boon @.***> wrote:

Will have to wait until .Net 8 becomes a release version merging to Release Candidates is not a good idea.

— Reply to this email directly, view it on GitHub https://github.com/Dartanlla/OWS/pull/127#issuecomment-1745147922, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEVYBTBFGERHLYAJHUULXDX5QRIXAVCNFSM6AAAAAA5A2HLFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGE2DOOJSGI . You are receiving this because you authored the thread.Message ID: @.***>

SloppyShovel commented 1 year ago

Oke but the LTS is .Net 7 not 8 latest release was Sept 12 2023 so i would make more sense to switch to .Net 7 and do LTS updates as we have always done rather then to skip and to testing for an RC version where things can change and break before it even gets released, to me it doesn't make much sense, you generally don't test against RC versions, testing against the current LTS and upgrade would make more sense.

But thats me.

miketoupin commented 1 year ago

.NET7 Never been LTS and never will. Last LTS was .Net6 and next one is .Net8. .Net7 is an STS.

Don't use the .Net8 if you don't need it, on my side I have no choice to use .Net8 as this is the only way to ensure containers are not running as root, this is one of the feature of .Net8 and Ubuntu/Alpine. It is possible with 7, but not as well integrated.

On Tue, Oct 3, 2023, 12:26 PM Kevin Boon @.***> wrote:

Oke but the LTS is .Net 7 not 8 latest release was Sept 12 2023 so i would make more sense to switch to .Net 7 and do LTS updates as we have always done rather then to skip and to testing for an RC version where things can change and break before it even gets released, to me it doesn't make much sense, you generally don't test against RC versions, testing against the current LTS and upgrade would make more sense.

But thats me.

— Reply to this email directly, view it on GitHub https://github.com/Dartanlla/OWS/pull/127#issuecomment-1745325180, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEVYBQMEWXIXJSEAHFAAADX5Q4BZAVCNFSM6AAAAAA5A2HLFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGMZDKMJYGA . You are receiving this because you authored the thread.Message ID: @.***>

SloppyShovel commented 1 year ago

I mean the Latest Release, not LTS yeah, will have to wait for the release i believe it's the end of the month or the beginning of November should be around that time.

I don't use it so it doesn't really matter to me if it's .Net 4 or 9 but if you working towards something stable using things in preview or rc generally just not a good idea, will have to see once it gets released

SloppyShovel commented 1 year ago

It's not on the main branch i'm just saying once it becomes a release version we can test it and merge it :)