search

DarthAffe / ScreenCapture.NET

Fast and easy to use screen-capturing
GNU Lesser General Public License v2.1
60 stars 10 forks source link

Igneom/master #4

Closed DarthAffe closed 2 years ago

DarthAffe commented 2 years ago

Follow up to #3 due to me being too stupid to push to the other pr ...

Igneom commented 2 years ago

Having a more generic method definitely is the way to go, since I was also thinking about eventually doing something in relation to the dimensions as well, just a little bit more complicated that handling the position. Updating only the position values seems to be fine, just like on my previous change, updating the dimensions present the same memory issues, as is expected since it's pretty much the same code, the advantage is that someone who may need it, will not need to implement outside anymore, which is good.

Since you opened this PR, and I can't change it, I made the above suggestions as well, not as much pertinent, but since there will be a version bump already, why not include such minor changes as well.