DarthFennec / highlight-indent-guides

Emacs minor mode to highlight indentation

572 stars 27 forks source link

Indent guides take on comment face #77

Open ColemanGariety opened 4 years ago

ColemanGariety commented 4 years ago

Commenting-out an indented block gives the indent guides the font-lock-comment-face. Thus unless your font-lock-comment-face is the same as your highlight-indent-guides-*-face, it will appear as thought comments have vertical lines. Seems confusing and non-standard.

ColemanGariety commented 4 years ago

This seems to be the opposite of #71 because, if I understand correctly, the guides do not take on the color of the selection, and so they stand out unnecessarily?

DarthFennec commented 4 years ago

71 is about how guides show through selection backgrounds, which is intended behavior. Your issue is not intended: the mode is written to completely remove guides from inside a comment when you add comment delimiters, and the same goes for strings. Does this happen only in specific situations, or any time you make a comment around guides? Does it work properly for you if you use an empty emacs configuration, where only this mode is loaded? There might be some conflict in your configuration that's causing it. Thanks for reaching out!

FabriceSalvaire commented 9 months ago

I observed an issue when we comment these lines (M-x comment-region)

(defun foo ()
  ...)

;; (defun foo ()
;; |  ...)

I also observed this issue with copy-paste.