search

DarthSim / overmind

Process manager for Procfile-based applications and tmux
MIT License
2.89k stars 82 forks source link

Fix #18 #19

Closed yewton closed 6 years ago

DarthSim commented 6 years ago

Hi! Thank you for your contribution! While using godotenv is a good idea, your code drops support of ./.overmind.env, ~/.overmind.env and OVERMIND_ENV. godotenv allows specifying custom filenames. Use this to restore dropped features and I'll merge the PR.

yewton commented 6 years ago

Thanks for your review!

I've also noticed that godotenv.Overload is more suitable than gototenv.Load here, so fixed that too!

Review it again, please 🙇

DarthSim commented 6 years ago

Thanks!