search

DarthSim / overmind

Process manager for Procfile-based applications and tmux
MIT License
2.84k stars 79 forks source link

Prevent cutting line when reading from procfile. #64

Closed terezka closed 4 years ago

terezka commented 4 years ago

Hello!

Thanks for making a great library- we very much enjoy it at NoRedInk! However, I ran into some trouble when my procfile had very long lines. I believe this fixes it, but of course, you will be the final judge of that. I realize sometime things are more complicated than they look!

Explanation for the fix: ReadLine() cuts off line when it gets too long for the buffer. ReadBytes('\n') does not. Read more here: https://golang.org/pkg/bufio/#Reader.ReadLine

Thanks for reading!

DarthSim commented 4 years ago

Hi Tereza,

Thanks for the contribution, but the problem was a bit complex. I fixed it with this commit https://github.com/DarthSim/overmind/commit/484043abb4c16de389bfcecbf0e52bd4e8f751b7