Overmind not properly passing PORT env on restart

DarthSim / overmind

Process manager for Procfile-based applications and tmux

MIT License

2.84k stars 79 forks source link

Overmind not properly passing PORT env on restart #68

Closed piotrb closed 4 years ago

piotrb commented 4 years ago

My Procfile has

web: bundle exec ./bin/rails server -p $PORT

in it ..

Everything works great on start ..

But when I restart the web process I get an error from the server something along the lines of

No value provided for option '--port'

Which to mean sounds like somehow $PORT is not being evaluated properly on restart ..

This used to work a few versions back I'm pretty sure ..

pnomolos commented 4 years ago

Looks like it's also not passing OVERMIND_STOP_SIGNALS properly, as I can only restart my web process once - it sends SIGUSR2 the first time, but SIGINT the next time.

On further investigation this is unrelated, as OVERMIND_STOP_SIGNALS is only parsed on the initial run of overmind

DarthSim commented 4 years ago

Fixed in v2.1.1