search

DarthSim / overmind

Process manager for Procfile-based applications and tmux
MIT License
2.84k stars 79 forks source link

Unable to stop #76

Closed mkasztelnik closed 4 years ago

mkasztelnik commented 4 years ago

I'm not able to stop overmind when sidekiq is defined in Procfile

jobs: bundle exec sidekiq -q computation -q mailers -q data_files -q notifications -q default

I have the following console output:

^Cjobs   | Interrupting...
jobs   | 2020-03-31T08:39:53.099Z pid=7029 tid=gq1pxscfd INFO: Shutting down
jobs   | 2020-03-31T08:39:53.099Z pid=7029 tid=gq1pxscfd INFO: Terminating quiet workers
jobs   | 2020-03-31T08:39:53.100Z pid=7029 tid=gq1qvod4l INFO: Scheduler exiting...
jobs   | 2020-03-31T08:39:53.200Z pid=7029 tid=gq1pxscfd INFO: Pausing to allow workers to finish...
jobs   | 2020-03-31T08:39:53.903Z pid=7029 tid=gq1pxscfd INFO: Bye!
jobs   | Killing...

It seems like the sidekiq is stopped (no process found in ps), but tmux session is not closed. After connecting to the jobs tmux session (overminc c jobs) Pane is dead message is shown.

Versions

franzliedke commented 4 years ago

I regularly encounter this issue as well.

If I can help you debug it, please let me know how. Unfortunately, I am not familiar with the inner workings of tmux.

Thanks for this great tool, anyhow!!!

agorf commented 4 years ago

I wanted to report this issue as well. Did not happen with an older version, so doing git bisect should find the commit that broke things.

mkasztelnik commented 4 years ago

5bad403c0db05015b7b7e0bc2cf7a5cd40d699d5 is the first commit in which described error occurs.

jamezrin commented 4 years ago

Happens to me too, it's kinda annoying, like me saying this.

DarthSim commented 4 years ago

Fixed this in 2.2.0