Closed pinealan closed 4 years ago
Hey @pinealan!
Thanks for your work, it's a pretty interesting idea. Though I cant merge it as is for the following reasons:
1) This PR breaks --root
flag. Actually, the whole idea of the --root
flag is not compatible with nested Procfiles as I see it. I can't say if --root
flag is somehow popular, but I can't remove it.
2) I don't like the idea of extending Procfile. Procfile is a universal format used by many systems and tools. If we add something Overmind-specific to this format, a Procfile become incompatible with the other tools. Thus it worth implementing a new format rather than extending the existing one.
you raised the exact same points as my team's senior engineer who introduced me to overmind :)
I see the concerns but I've already been rolling this for my own projects and like it a lot, so I guess I'll have to keep my own fork
Implements the following to allow a Procfile to include other Procfiles to
-f <path>
entries in a Procfile-c [working-directory]
flagAn example setup in a repo with 1 top-level Procfile and 2 nested Procfiles
To distinguish between processes started from different Procfiles, the relative directory path will be appended to each proc
A few undetermined behaviors with other existing flags that I'd like to hear the maintainer's opinions on:
procfile
is not./Procfile
root
is not directory containing top Procfile