search

DarthTon / HyperBone

Minimalistic VT-x hypervisor with hooks
MIT License
825 stars 262 forks source link

reserved identifier violation #10

Open elfring opened 7 years ago

elfring commented 7 years ago

I would like to point out that identifiers like “_EFLAGS” and “_CPU_VENDOR” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

DarthTon commented 7 years ago

It's unlikely that I'll change the code to be fully compatible with C standard. I doubt it can cause any real conflicts and compiler will give warning if anything goes wrong.

elfring commented 7 years ago

How do you think about to avoid that this software depends on undefined behaviour?

DarthTon commented 7 years ago

It doesn't depend on it. It may have undefined behavior because of reserved identifier conflict, but it's the smallest issue here.