search

Darthagnon / hugo-easy-gallery

Automagical css image gallery in Hugo using shortcodes, with optional lightbox/carousel gadget using PhotoSwipe and jQuery.
MIT License
29 stars 4 forks source link

Trim down Bootstrap #1

Closed Darthagnon closed 1 year ago

Darthagnon commented 1 year ago

Bootstrap is required for the image grid, but is otherwise overkill. It needs trimming down to the bare minimum required for the responsive square grid.

Probably should also be updated from v3.7.7, which I lifted from Beautiful Hugo

Darthagnon commented 1 year ago

@nunocoracao, would you be interested in helping with this issue?

Any advice you might have would be appreciated, since you know CSS frameworks much better than I

Darthagnon commented 1 year ago

Working on it in this branch: https://github.com/Darthagnon/hugo-easy-gallery/tree/remove-bootstrap

Darthagnon commented 1 year ago

Merged changes, fixed. Will close soon, after my friend nunocoracao has had a chance to look

nunocoracao commented 1 year ago

@Darthagnon sorry, a little lost here... that branch does not exist anymore and there is no PR to look at... which changes do you want me to look at?

nunocoracao commented 1 year ago

Until you get back to me, you can consider using NPM to manage your dependencies. That way you can setup GitHub dependabot to generate PRs bumping the versions every time there is an update. That plus GitHub actions for automation can make your life easier.

You can check Blowfisth for a IRL example of what I am saying.

Darthagnon commented 1 year ago

My bad; I must have been programming this one late at night and forgot I deleted the branch - I added Bootstrap temporarily in 8f8c736823bc450e01b7273e822d3be02bf89f4e and removed it (after isolating what was needed) in f769bdf415dad430d9ecce36e4ac378b411a2041 and forwards. It seems to work in production, so unless anything turns up, seems to be solved.

Darthagnon commented 1 year ago

Thank you for your suggestions, @nunocoracao! I'll try implementing that where I need updated dependencies, though for the moment, this repo's only dependency is Photoswipe, intentionally kept on an older version for compatibility.