DarvinArroyo / peerblock

Automatically exported from code.google.com/p/peerblock
Other
0 stars 0 forks source link

Show 32bit or 64bit PeerBlock in log. #392

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I suggest adding "(32bit)" and "(64bit)" (depending on which version of Windows 
you are running) at the end of the PeerBlock version line in logging. I think 
this should be added to help verify that people are running the correct version 
of PeerBlock for their OS.

Current output:

Logging Started...
[3/13/2011] [20:03:26.182] [20656]  PeerBlock Starting
[3/13/2011] [20:03:26.182] [20656]  PeerBlock 1.0+ (r404) - BETA RELEASE
[3/13/2011] [20:03:26.182] [20656]  Flushed tracelog
[3/13/2011] [20:03:26.185] [20656]  Running on OS: Windows Server 2008 64-bit - 
Build:[6001], SP:[1.0]
[3/13/2011] [20:03:26.185] [20656]  User running as Admin

Suggested output:

Logging Started...
[3/13/2011] [20:03:26.182] [20656]  PeerBlock Starting
[3/13/2011] [20:03:26.182] [20656]  PeerBlock 1.0+ (r404) - BETA RELEASE 
(64bit) 
[3/13/2011] [20:03:26.182] [20656]  Flushed tracelog
[3/13/2011] [20:03:26.185] [20656]  Running on OS: Windows Server 2008 64-bit - 
Build:[6001], SP:[1.0]
[3/13/2011] [20:03:26.185] [20656]  User running as Admin

Original issue reported on code.google.com by ineedali...@gmail.com on 18 Mar 2011 at 8:18

GoogleCodeExporter commented 8 years ago
I've got the 1.1 r518 stable version.  The log doesn't even show the release 
number, only "Peerblock 1.1"

Original comment by bmar...@gmail.com on 18 Jul 2011 at 8:59

GoogleCodeExporter commented 8 years ago
Cause that's how the version string is set up.

http://code.google.com/p/peerblock/source/browse/trunk/src/peerblock/versioninfo
.h

#ifdef PB_RELTYPE_STABLE
        #define PB_BLDSTR "PeerBlock " STRINGIFY(PB_VER_MAJOR) "." STRINGIFY(PB_VER_MINOR)
#endif

As for the 32bit or 64bit build, it's useless since you can't use the 32bit 
build on 64bit Windows and vice versa. Which means, the OS info is enough.

Original comment by XhmikosR on 2 Aug 2011 at 11:21