Darwin-Coin / darwin-token-contracts

Darwin Protocol Smart Contracts
https://darwinprotocol.io
0 stars 0 forks source link

Inherit from Openzeppelin ERC20 #21

Closed kingofclubstroyDev closed 1 year ago

kingofclubstroyDev commented 1 year ago

We should inherit from ERC20 and override any functions we add functionality to, it will clean up the codebase, and it much less error prone

SonOfMosiah commented 1 year ago

Has any work been done on this issue? If not, I'd be happy to take over the assignment.

kingofclubstroyDev commented 1 year ago

You can go ahead

kingofclubstroyDev commented 1 year ago

If we can inherit from ERC20PausableUpgradeable, and override the _requireNotPaused as required, and implement a pause/unpause function callable by the owner

thesios commented 1 year ago

wait not for darwin it could mess up big time

thesios commented 1 year ago

we are NOT moving fwd with making darwin an ERC20 compatible as I think it will may raise too many issues.

Just by looking at the code , I can tell it is a reflection contract and the mostly look the same