DarwinAwardWinner / ido-completing-read-plus

Fancy completion all over Emacs, not just for buffers and files.
GNU General Public License v3.0
241 stars 31 forks source link

s-left used, not imported #130

Closed michaelcadilhac closed 7 years ago

michaelcadilhac commented 7 years ago

At some place, the package uses the function s-left from the s package, but the s package is never required, nor is it a dependency on MELPA.

DarwinAwardWinner commented 7 years ago

Thanks for catching this. I declared the dependency in the Cask file in the repo, but MELPA doesn't get its dependency info from that. And then the test suite requires s, so s is always loaded during testing, preventing discovery of this problem.

michaelcadilhac commented 7 years ago

My, you didn't even leave me enough time to wait. Thanks!