search

DarwinAwardWinner / ido-completing-read-plus

Fancy completion all over Emacs, not just for buffers and files.
GNU General Public License v3.0
241 stars 31 forks source link

Use memoization to simplify dynamic collection logic? #131

Closed DarwinAwardWinner closed 7 years ago

DarwinAwardWinner commented 7 years ago

See https://github.com/skeeto/emacs-memoize.

DarwinAwardWinner commented 7 years ago

If speed becomes an issue later, I can revisit this.

DarwinAwardWinner commented 7 years ago

Reopening because this will make it easier to solve #133.

rprimus commented 7 years ago

Sun Aug 13 19:33:43 BST 2017

Requiring 'memoize' completely breaks emacs. Every operation yields:

Cannot open load file: No such file or directory, memoize

emacs must be stopped with kill -9

Is there a way to state (in the package description) that emacs-memoize is a required package and have emacs automatically install the package?

EDIT:

As it's not a melpa package, it would be good to include it with this package.

DarwinAwardWinner commented 7 years ago

Memoize is definitely a MELPA package: http://melpa.org/#/memoize. ido-cr+ version 4.4 had an issue where the memoize dependency was not declared correctly, so MELPA didn't pick it up. This should be fixed in 4.5.

rprimus commented 7 years ago

Sun 13 Aug 2017 20:30:32 BST

Ahhh - coolio. emacs -q and package-list-packages didn't show it.

Have just pulled the new version!

Cheers!!