search

DarwinAwardWinner / ido-completing-read-plus

Fancy completion all over Emacs, not just for buffers and files.
GNU General Public License v3.0
241 stars 31 forks source link

Problem with Magit #140

Closed contrapunctus-1 closed 5 years ago

contrapunctus-1 commented 7 years ago

GNU Emacs 24.5.1 (i686-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-09-12 on x86-grnet-01, modified by Debian ido-ubiquitous v4.2, commit hash 02f21215ce5ef2234c0e58dac9ec181cfc0900c1

Steps to reproduce

  1. Enable ido-ubiquitous-mode
  2. Run magit-status
  3. Place point at a filename
  4. Type E s or M-x magit-ediff-stage
  5. Error message - Invalid function: ("<filename>.<extension>") Backtrace (Somehow, I could never paste the entire backtrace here - it always got truncated after some point.)

Error does not occur with ido-ubiquitous-mode disabled.

DarwinAwardWinner commented 7 years ago

Can you indicate the values of ido-cr+-function-blacklist? It should contain magit-builtin-completing-read. If it doesn't, can you run ido-cr+-update-blacklist and try again?

contrapunctus-1 commented 6 years ago

Sorry I took so long to get back on this - ido-cr+-function-blacklist does contain magit-builtin-completing-read -

(read-file-name-internal read-buffer todo-add-category gnus-emacs-completing-read gnus-iswitchb-completing-read grep-read-files magit-builtin-completing-read ess-completing-read Info-read-node-name tmm-prompt)

DarwinAwardWinner commented 6 years ago

Hmm. If magit-builtin-completing-read is in ido-cr+-function-blacklist, then ido-cr+ should never even be used, unless you've set magit-completing-read-function to magit-ido-completing-read.

contrapunctus-1 commented 6 years ago

The value of magit-completing-read-function is magit-builtin-completing-read.

DarwinAwardWinner commented 6 years ago

Ok. So ido completion should never even be happening, which makes this error very weird. Could you post the stack trace again? The original paste seems to have expired. I'll save it to my disk this time.

contrapunctus-1 commented 6 years ago

http://paste.debian.net/993940/

DarwinAwardWinner commented 6 years ago

I'm sorry I didn't get to the second paste in time either. Could you just email the backtrace to me? (Find my email in my profile.)

DarwinAwardWinner commented 5 years ago

As this has been inactive for over a year, I'm going to close it. Please create a new issue if this is still a problem.