search

DarwinAwardWinner / ido-completing-read-plus

Fancy completion all over Emacs, not just for buffers and files.
GNU General Public License v3.0
241 stars 31 forks source link

Use ‘condition-case-unless-debug’ to suppress errors. #145

Closed phst closed 6 years ago

phst commented 6 years ago

With ‘condition-case-unless-debug’ users can still debug errors during dynamic expansion by setting ‘debug-on-error’ to t.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-34.0%) to 58.427% when pulling 3257740f65d5e40d91503a4ecb8008763b828e08 on phst:ccud into 34374f498f3d52f225c00803c0500ef23a2dbe10 on DarwinAwardWinner:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-34.0%) to 58.427% when pulling 3257740f65d5e40d91503a4ecb8008763b828e08 on phst:ccud into 34374f498f3d52f225c00803c0500ef23a2dbe10 on DarwinAwardWinner:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-34.0%) to 58.427% when pulling 3257740f65d5e40d91503a4ecb8008763b828e08 on phst:ccud into 34374f498f3d52f225c00803c0500ef23a2dbe10 on DarwinAwardWinner:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-34.0%) to 58.427% when pulling 3257740f65d5e40d91503a4ecb8008763b828e08 on phst:ccud into 34374f498f3d52f225c00803c0500ef23a2dbe10 on DarwinAwardWinner:master.

DarwinAwardWinner commented 6 years ago

I think the tests use the debugger for calculating coverage The testing framework I use, buttercup, uses the debugger to catch errors with their stack traces during testing, which interacts badly with this change. I'll have to look into fixing the tests.