Clean up idle time advice

DarwinAwardWinner / with-simulated-input

Test your interactive elisp functions non-interactively!

GNU General Public License v3.0

38 stars 4 forks source link

Clean up idle time advice #14

Closed nbfalcon closed 3 years ago

nbfalcon commented 3 years ago

Add an unload-function, so that M-x unload-feature with-simulated-input causes the current-idle-time advice to be removed
Rename current-idle-time@simulated-idle-time -> with-simulated-input--current-idle-time-a, adding the package prefix
#' uses of it in advice-add

DarwinAwardWinner commented 3 years ago

Note that I chose the name current-idle-time@simulated-idle-time for the advice function based on what define-advice would use, if I was using it, which I don't because it doesn't exist in Emacs 24. (Essentially, I just manually macro-expanded the define-advice form I would have used.) Is there actually a standard recommended naming convention for advice functions?

nbfalcon commented 3 years ago

I am not aware of such a convention, but DOOM Emacs uses doom-<short-description-with-dashes>-a.

DarwinAwardWinner commented 3 years ago

I've now merged the changes for bullet points 1 and 3 above, but I don't think I'm going to change the advice function names. Unless there's some clear style guidance for naming advice, I'm going to stick with the naming scheme used by define-advice. Eventually I will drop support for Emacs 24 and switch to actually using define-advice.