Closed nbfalcon closed 3 years ago
Note that I chose the name current-idle-time@simulated-idle-time
for the advice function based on what define-advice
would use, if I was using it, which I don't because it doesn't exist in Emacs 24. (Essentially, I just manually macro-expanded the define-advice
form I would have used.) Is there actually a standard recommended naming convention for advice functions?
I am not aware of such a convention, but DOOM Emacs uses doom-<short-description-with-dashes>-a
.
I've now merged the changes for bullet points 1 and 3 above, but I don't think I'm going to change the advice function names. Unless there's some clear style guidance for naming advice, I'm going to stick with the naming scheme used by define-advice
. Eventually I will drop support for Emacs 24 and switch to actually using define-advice
.
unload-function
, so thatM-x unload-feature
with-simulated-input
causes thecurrent-idle-time
advice to be removedcurrent-idle-time@simulated-idle-time
->with-simulated-input--current-idle-time-a
, adding the package prefix#'
uses of it inadvice-add