DarwinNE / FidoCadJ

FidoCadJ is a free user-friendly vector graphic editor for MacOSX, Linux, Windows and Android with a library of electronic symbols.
http://darwinne.github.io/FidoCadJ/
GNU General Public License v3.0
113 stars 40 forks source link

Improved dev tools and fixed javadoc generating errors. #108

Closed DanteCpp closed 8 years ago

DanteCpp commented 8 years ago

Change log:

Remember do not use, or correctly escape the special characters <>"'\& in the comments.

DarwinNE commented 8 years ago

Nice work, @DanteCpp, thanks!

DarwinNE commented 8 years ago

Hi again, @DanteCpp, i ran some tests with Checkstyle.

Be careful about the line length and do not use tabs in the code or trailing spaces. Checkstyle complains about that. Have a look here: https://github.com/DarwinNE/FidoCadJ/blob/506259b/dev_tools/fidocadj_check.txt Can you please correct that?

Kind regards, D.

DanteCpp commented 8 years ago

Hi @DarwinNE, it is pretty strange, because if you manually check some accused file, you can see it do not over length 80 characters.

Anyway you are right about the tabulations.

What is the correct work flow for the checkstyle analysis?

Cheers, Dante.

DarwinNE commented 8 years ago

Hi @DanteCpp, I see that. Probably it is because Checkstyle considers that a single tab contains 8 spaces instead of 4. Problems of this kind should be avoided by avoiding tabs at all.

To employ checkstyle, you can download Checkstyle here:

http://checkstyle.sourceforge.net

then put the jar file somewhere in your disk. Then, you employ the checkstyle script as follows:

[davidebucci@davide-bucci-portable]$ cd dev_tools/
[davidebucci@davide-bucci-portable]$ ./checkstyle.sh ~/CodeAnalysis/checkstyle/checkstyle-6.10-all.jar
Checkstyle results stored in fidocadj_check.txt
lines on fidocadj_check.txt
     805 fidocadj_check.txt
[davidebucci@davide-bucci-portable]$ 

Where the ~/CodeAnalysis/checkstyle/checkstyle-6.10-all.jar is the path where I put the Checkstyle jar file.

It is a tremendously useful and wonderful program.

Cheers, D.

DanteCpp commented 8 years ago

Thanks, yes it is really a useful tool!