search

DarwinNE / FidoCadJ

FidoCadJ is a free user-friendly vector graphic editor for MacOSX, Linux, Windows and Android with a library of electronic symbols.
http://darwinne.github.io/FidoCadJ/
GNU General Public License v3.0
113 stars 40 forks source link

Improved the compile script #113

Closed DanteCpp closed 8 years ago

DanteCpp commented 8 years ago

Dear @DarwinNE, I improved the compile script. Now, you are able to turn on/off the debugging options and chose if compile the applets.

Examples

make command compiles just the FidoCadJ code, without debugging options.

make ARGS="-debug -all -mac" command compiles the FidoCadJ and applets code, with debugging options and mac special classes.

All options

Option Description
-debug Debugging options
-all Compile all
-applets Compile just the applets
-mac Compile the mac classes

Is better do not distribute java bins with debugging metadata.

Is there a performance difference between Javac debug on and off?

Cheers, Dante.

DarwinNE commented 8 years ago

Hi @DanteCpp thanks for the work. I see that -mac option is automatically active when the scripts are run on a Macintosh, that's correct.

However, you specifically require Java 8. I do not think it is a good thing to do (at least for another two or three years): FidoCadJ is meant to run on a very wide range of computers which may include some almost obsolete hardware. You should not expect that everyone runs Java 8 (I still am using 7, for example).

I do not think it is now the right time to require java 1.8, especially since Java 1.7 is still supported by Oracle and critical issues are patched regularly.

Cheers, D.

DarwinNE commented 8 years ago

Hi again, I forgot to mention that I just committed 6c53b87f513ab2e0f75e6d2b7a5fad98d1e8b295 to go for Java 1.7.

Cheers, D.

DanteCpp commented 8 years ago

I've got it.