search

DarwinNE / FidoCadJ

FidoCadJ is a free user-friendly vector graphic editor for MacOSX, Linux, Windows and Android with a library of electronic symbols.
http://darwinne.github.io/FidoCadJ/
GNU General Public License v3.0
113 stars 40 forks source link

Updated Dutch translations #124

Closed lucaslampe closed 7 years ago

lucaslampe commented 7 years ago

Fixes #28

DarwinNE commented 7 years ago

Hi @lucaslampe, thank you very much! Your contribution is truly useful since the last Dutch translation of the interface was done a few years ago.

I have just a question: in some resources, I noticed that you removed the spaces at the end of the line. This is mandatory for the Java code, but for the text resources in the interface sometimes the spaces are useful and should be kept in place. For example, for resource "Open_error" the space is needed after the ":" since the file name is added after it. Therefore, without a space the resource may be rendered as follows:

Fout openen bestand:file.fcd

instead of:

Fout openen bestand: file.fcd

where the latter would be more correct and aestetically pleasing. Did you remove the spaces by purpose or it was a feature of your editor? Can you please restore those spaces (if their rendering in Dutch is correct, of course).

I will leave open this PR for the moment, I will merge it in the future.

Kind regards and thanks again!

Davide

lucaslampe commented 7 years ago

Woops, no idea how this happend. 😅 I've fixed all of them now.

DarwinNE commented 7 years ago

Hi @lucaslampe No problem at all, just check for the other resources. There are a few of them where there is a space in the last character of the line. You should probably do not remove it! Open_error is an example, but there are other resources. Check the diffs!

Cheers,

Davide