DarwinNE / FidoCadJ

FidoCadJ is a free user-friendly vector graphic editor for MacOSX, Linux, Windows and Android with a library of electronic symbols.
http://darwinne.github.io/FidoCadJ/
GNU General Public License v3.0
113 stars 40 forks source link

Package names refactoring #237

Closed manufino closed 4 weeks ago

manufino commented 1 month ago

On my fork, I performed a complete refactoring of the package names. In projects like this, it doesn't make sense to apply the Oracle convention, for example:

import fidocadj.dialogs.ParameterDescription;
import fidocadj.dialogs.LayerInfo;
import fidocadj.export.ExportInterface;
import fidocadj.geom.MapCoordinates;
import fidocadj.geom.GeometricDistances;
import fidocadj.globals.Globals;
import fidocadj.layers.LayerDesc;
import fidocadj.graphic.DecoratedText;
import fidocadj.graphic.PointG;
import fidocadj.graphic.DimensionG;
import fidocadj.graphic.GraphicsInterface;

It's better than this:

import net.sourceforge.fidocadj.dialogs.ParameterDescription;
import net.sourceforge.fidocadj.dialogs.LayerInfo;
import net.sourceforge.fidocadj.export.ExportInterface;
import net.sourceforge.fidocadj.geom.MapCoordinates;
import net.sourceforge.fidocadj.geom.GeometricDistances;
import net.sourceforge.fidocadj.globals.Globals;
import net.sourceforge.fidocadj.layers.LayerDesc;
import net.sourceforge.fidocadj.graphic.DecoratedText;
import net.sourceforge.fidocadj.graphic.PointG;
import net.sourceforge.fidocadj.graphic.DimensionG;
import net.sourceforge.fidocadj.graphic.GraphicsInterface;

This is my opinion; what do you think?

DarwinNE commented 1 month ago

I fully agree!

manufino commented 1 month ago

This implementation is included in my pull request #240

manufino commented 4 weeks ago

I think this can be closed.