DarwinsBuddy / WienerNetzeSmartmeter

A home-assistant integration supporting WienerNetze Smartmeters as sensors
144 stars 15 forks source link

implement new API app-config.json #248

Closed reox closed 3 months ago

reox commented 3 months ago

may fix #246 and #247

Please check if it works for you as well!

reox commented 3 months ago

ah of course - someone has to fix the tests now 😅

papedo79 commented 3 months ago

worked for me. Thanks!

adamnet01 commented 3 months ago

Hi, how to add these fixes? Copy to wnsm directory and restart homeassistant?

papedo79 commented 3 months ago

Hi, how to add these fixes? Copy to wnsm directory and restart homeassistant?

i changed the code lines as stated in files changed, saved and restarted homeassistant

although the login works, they also changed something in the smartmeter website, so the data is represented now in a different way and for me there is no new data available since 2 days

wceleda commented 3 months ago

changed the codes lines as mentioned for client.py and constant.py but nothing has changed, no new data since 31.7.24

tschoerk commented 3 months ago

changed the codes lines as mentioned for client.py and constant.py but nothing has changed, no new data since 31.7.24

Did you restart home assistant after the code changes? Only then it uses the updated files.

wceleda commented 3 months ago

changed the codes lines as mentioned for client.py and constant.py but nothing has changed, no new data since 31.7.24

Did you restart home assistant after the code changes? Only then it uses the updated files.

yes

wceleda commented 3 months ago

put API_CONFIG_URL = "https://smartmeter-web.wienernetze.at/assets/app-config.json" in old constants.py and restarted ha and now data ist displayed.

slettmayer commented 3 months ago

That change fixed https://github.com/DarwinsBuddy/WienerNetzeSmartmeter/issues/246 and https://github.com/DarwinsBuddy/WienerNetzeSmartmeter/issues/247 for me. Thanks ❤️

akicker commented 3 months ago

implemented new API app-config.json and its working again :-)

gotaede commented 3 months ago

Fixed it for me.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.46%. Comparing base (28431d8) to head (97b3855).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== + Coverage 78.30% 81.46% +3.16% ========================================== Files 5 5 Lines 295 286 -9 ========================================== + Hits 231 233 +2 + Misses 64 53 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reox commented 3 months ago

thanks @tschoerk for fixing the tests!

DarwinsBuddy commented 3 months ago

thank you so much for taking care. I was on vacation and couldn't look into it. :heart:

And thanks A LOT, for reaching the test coverage threshold!