search

DarylJtn / AliExpress-popup-blocker

New customer popup blocker
MIT License
1 stars 2 forks source link

Blocking of 'Subscribe' and 'don't waste this discount' popups #2

Open daxliniere opened 2 years ago

daxliniere commented 2 years ago

Hi Daryl, Firstly, thanks for this extension.

I installed your extension in Chrome, but found that these two popups are still being shown. Any ideas on how to stop these popups? I think it might have something to do with the USL being different. Seems like in the settings it should be *.aliexpress.com not www.aliexpress.com. Does that sound right to you?

All the best, Dax.

AliExpress popups

daxliniere commented 2 years ago

I tried editing the manifest.json file to change *"matches": [ "https://www.aliexpress.com/" ] to "matches": [ "https://*.aliexpress.com/*" ]**, but the extension settings page still shows www

DarylJtn commented 2 years ago

Hi, Thanks for taking the time to make a pull request. Yes it looks like it wasn't applying all the changes to all the pages. I think the popup class name has changed as well causing it to not block the popup.

I will merge these changes and deploy them later today.

I seems that ublock origin is now blocking these popups so its probably best to use that extension as they will probably do a better job at keeping the filter rules up to date.

Thanks