DasHomi / preventer

A mod that prevents you from doing dumb things
https://modrinth.com/mod/preventer
MIT License
10 stars 5 forks source link

Prevent firework rocket use option no longer works #44

Closed Jim3535 closed 10 months ago

Jim3535 commented 10 months ago

This option used to work, but now the game lets you launch rockets up into the air if you are standing on the ground.

Steps to reproduce:

  1. Turn prevent firework rocket on
  2. Select rockets in your hotbar
  3. Point the crosshair at the ground near you and right click

Environment:

latest.log

2023-11-13_12 25 18

DasHomi commented 10 months ago

Maybe I misunderstand the issue, but I have not been able to reproduce it. In my tests, with the option enabled, i can't launch rockets. Are you sure you have enabled the "Prevent firework rocket use" for the hand in which you are using the rockets? What blocks are you targeting while the rockets are still being launched?

Jim3535 commented 10 months ago

I was confused about your question about which hand would be prevented from using rockets. I dug through the menus and managed to find the setting. It turns out it works if I turn off firework use for the main hand (and I left the off hand "prevented" too).

What's odd is that it used to work, and I didn't change any config settings, so I don't know how it stopped working unless the setting is new. In either case, it might not be the best UI to split the options to separate tabs without a note or indicator.

DasHomi commented 10 months ago

Yes, you are right. I'll add a note to the option that it can be configured further under the config tab until I find a way to add dropdowns (which would be my preferred place to add the options). Do you know which preventer version you used when it was still working?

Jim3535 commented 10 months ago

I'm not sure. I tried testing the beta version for 1.20 since it's the only other one listed on modrinth. It still works like the newer version.

I'm going to close this out as a combination of user error and UI that's not clear. There's aways a chance that I just never triggered rockets on the ground while in the main hand. It doesn't seem worth chasing that thread.