search

Dasfaust / GlobalMarket

Buy and sell items in a global market
Other
28 stars 59 forks source link

*.37 inventory glitch #124

Closed freakyy85 closed 7 years ago

freakyy85 commented 8 years ago

Everytime I enable the Economy PLugin together with GlobalMarket, items in the inventory glitch when I press shift+rigthclick. can you please fix this? Heres a video showing it. https://youtu.be/s_Dt9KBkk5Q When having Economy + Vault put in the plugins folder, and also putting GlobalMarket in starts the bug. Is that possible? :)

Dasfaust commented 8 years ago

I think I was able to reproduce this... Just to verify, when shift+click crafting, 32*4 sticks for example, I receive a stack of 60, 64, and 4. Is that the issue? Should be two stacks of 64.

freakyy85 commented 8 years ago

yes exactly that!

freakyy85 commented 7 years ago

can you do something about it? :)

freakyy85 commented 7 years ago

hello? :D

SimonVanacco commented 7 years ago

Got the same problem, really a huge problem for my server. Got any workarounds?

Dasfaust commented 7 years ago

Sorry for my absence, been busy with work, unfortunately. Build 38 should fix, if someone wants to confirm.

freakyy85 commented 7 years ago

for me the bug is still present but it might be caused by multiple plugins.

freakyy85 commented 7 years ago

galaxias, maybe we should get in touch because fo the problem? i mean we both have the problem maybe we can check what plugins we have both or something and test it out?

Dasfaust commented 7 years ago

@freakyy85 I suppose it's possible if another plugin is using ProtocolLib in the way that I am. I can no longer reproduce the issue with build 38. Seems like a ProtocolLib bug to me, you must pass an ItemStack to MinecraftReflection before using the NBT functions. Will cause the stacking issue unless you clone the ItemStack first.

Think I'm going to write my own reflection utilities and drop ProtocolLib in a later version for a better understanding anyways.

freakyy85 commented 7 years ago

hm ok ... i even have the problem when just shift clicking on 34 sticks. they keep unstacking.

freakyy85 commented 7 years ago

well, i removed protocollib but the bug still happens.

SimonVanacco commented 7 years ago

I'll try the plugin in tomorrow :) Thank you for the build @Dasfaust. @freakyy85 --> After removing GlobalMarket, the bug disappeared for me, so it's definitely from this plugin for me.

SimonVanacco commented 7 years ago

I can't reproduce yet with build 38. I'll let you know if it happens again. Thank you all. ( @freakyy85 You should really see which of your plugins uses ProtocolLib! )

The issue should be closed for me.

freakyy85 commented 7 years ago

cant protocollib fix it? can you maybe ask them to fix it? tell them what the problem is etc.?

Dasfaust commented 7 years ago

I will have to do more testing before submitting a bug report, it's just a hunch. It may also be a bug in Spigot related to CraftItemStack, as ProtocolLib uses reflection to access that class.

freakyy85 commented 7 years ago

ok so, if uve done more testing will u submit a bugreport to the responsible people?

freakyy85 commented 7 years ago

ok when uve done more testing, will u report the bug and how long would that take?

dwatsX commented 7 years ago

although build 38 did not fix this issue for me initially, installing the new version of ProtocolLib which was released today, has fixed this for me.

dwatsX commented 7 years ago

apparently 1.11.2 has made this an issue again. It's not the same as before though. Items seem to properly stack in players' inventories, but they will not stack properly when shift+clicking items into chests. In most cases, players have to manually stack items in their inventories before placing the items into a chest.

Dasfaust commented 7 years ago

1.11.2 has been working fine for me - can't reproduce the bug. Also can't say when I'd be able to submit a proper bug report to the ProtocolLib people.