Dasfaust / GlobalMarket

Buy and sell items in a global market
Other
28 stars 59 forks source link

Player permissions not working #88

Closed tylerking closed 6 months ago

tylerking commented 8 years ago

Currently the commands can only be used if you are OP. I use zPermissions and gave my default players the globalmarket.use permission node but they were still unable to list market items.

Pigna commented 8 years ago

How do your players use the market? what command?

In the version 2.0 (Beta) The players are suppose to add items without a command. /market -> Listings -> Drop item on a class pane -> Right click it -> Use [1-9] keys while hovering over left item to increase price, hover over right and [1-9] to increase ammount to sell for that price.

then click the green pane to confirm the enlisting. U can drop to a maximum om 320 items on the enlisting. It will sell for that price untill there are nomore items left in the enlisting.

Still questions? Ill be glad to awnser them.

StargateMC commented 8 years ago

In 2.0 You can list items using /market create. There are serious bugs with 2.0 though (i.e You cant create server listings at all...) I'd recommend jumping back to 1.3.x.

PS: Add Bukkit/Spigot/Cauldron version too ;)

Time6628 commented 8 years ago

@DraksterAU I can create server listings just fine with GM2. Make sure you installed it right.

StargateMC commented 8 years ago

@Time6628 Build 26+? How are you making them?

Time6628 commented 8 years ago

./market createinf price amount

tylerking commented 8 years ago

I used the /market command as well and it's definitely broken and it's not because I didn't install the plugin right. I'm running on Spigot 1.9.2 and there is no errors in console. It does tell me that I need to be holding an item in my hand but I am holding an item do that's wrong too.

Time6628 commented 8 years ago

@doitliketyler Did you install the ProtocolLib? If you did, did you install the right version?

tylerking commented 8 years ago

Yes.

Time6628 commented 8 years ago

Don't know then. Everything works fine for me.

NoHoPeLess commented 8 years ago

Yes permissions and the createserverlisting command dont work anymore... anyone can help or is this for the moment broken?

StargateMC commented 8 years ago

I've just stayed ok 1.3.... Haha

Will wait for this to be fixed - along with the others

Dasfaust commented 8 years ago

Sorry, busy month. I use also zPermissions and don't seem to have this issue. I've added debug output to commands in the latest build if you want to try that. Enable debug output in your config, restart, and you should see something like "Permissions check on player for permission has returned true/false".

StargateMC commented 8 years ago

@Dasfaust There are several other game breaking bugs (like inability to create a server listing) with your latest 2.0 builds man :) Just making sure your aware haha (all are on GitHub)

NoHoPeLess commented 8 years ago

any chance when u have time u update this?

NoHoPeLess commented 8 years ago

also i mean all the bugs? glitching dupe etc ?

Dasfaust commented 8 years ago

The latest build has an untested fix for createserverlisting. There's no dupe bugs to my knowledge, the last one reported was fixed.

NoHoPeLess commented 8 years ago

When im at home, i make an video :D

NoHoPeLess commented 8 years ago

Here you can see the bug: https://youtu.be/HyRkMxfL5RY

Dasfaust commented 8 years ago

That's just CraftBukkit/Spigot being wonky. There's improvements to be done but I don't see any duplication happening there so it's low priority.

StargateMC commented 8 years ago

@Dasfaust so your opinion is 2.0 is ready for production then? Minus the minor graphical glitches?

Time6628 commented 8 years ago

@Dasfaust Don't mean to burst your bubble, but the commit to fix createserverlisting breaks all market subcommands. I believe the problem is that it searches for what the subcommand starts with, "createinf" doesn't work because it starts with "create" so the plugin will try to do the create subcommand. Same for list. The simple fix for this is to add another alias for createserverlisting/createinf/listinf. :cat:

NoHoPeLess commented 8 years ago

@Dasfaust with this glitch my items are away..low priority?

Dasfaust commented 8 years ago

I've had an 11-day stretch at work, so sorry for no updates. @NoHoPeLess the easy fix is just to not put items in empty inventory slots, and inform your players to do the same. You're only supposed to swap items into inventory slots containing the black stained panes, if you want more slots available adjust your config values. I doubt I can fix it as the events are already cancelled and it seems to be a Bukkit issue.

I've committed a tested fix for infinite listings. See the commit for details (the command name and permissions have changed.)

As for permissions not working, I have no idea. I run zPermissions on the latest Spigot build and have checked all permissions with /perms check, my character is not OP, and all seem to be working fine. I set 'globalmarket.use' to false on the default group and was successful.

StargateMC commented 8 years ago

+1 to reproducing @NoHoPeLess issue in v1.7.10 with Thermos (Cauldron) @Dasfaust Are you sure it isn't an array length issue at some point in your code? Like, youre not subtracting 1 where you should because it starts at zero? EDIT: Nevermind, happens with other slots.

Dasfaust commented 8 years ago

Happens in 1.9 too. I can only get the item to stay in the slot via spam-clicking it in, so it's weird. I'm thinking about filling all unused slots with gray stained glass panes as a quick fix.

StargateMC commented 8 years ago

@Dasfaust Make the panel a diff color glass slot and bingo, that's perfect. PS: Happens on 1.7