Dash-Industry-Forum / MPEG-Conformance-and-reference-source

Contains several MPEG reference software modules. Not actively maintained. The ISOSegmentValidator is moved to - https://github.com/Dash-Industry-Forum/ISOSegmentValidator
21 stars 31 forks source link

The Windows build fails due to non-standard C++ code #39

Open andyburras opened 6 years ago

andyburras commented 6 years ago

for (int j = i; list[j].offset < (offset + segmentSizes[index]); j++) { ... } errprint("[...]",index, list[j].offset);

Does not obey C++ standard rules - the scope of the name(s) declared extends to the end of the for statement.

char vsdi_name[strlen(vsdi.name)]; and saio_offset ...

Using non-standard C++ dynamic array lengths - (this has been adopted by the C standard and is supported in g++, but it is not in the C++ standard).

true and false are #defined.

C++ Standard Library forbids macroizing keywords