Dash-Industry-Forum / dash.js

A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.
http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html
Other
5.1k stars 1.67k forks source link

Fragmented WebVTT and Sidecar WebVTT are displayed double in Chrome/Firefox, broken on Edge #2689

Closed unifiedstreaming closed 6 years ago

unifiedstreaming commented 6 years ago
Environment
Steps to reproduce
  1. Please provide clear steps to reproduce your problem

Load http://reference.dashif.org/dash.js/v2.8.0/samples/dash-if-reference-player/index.html?mpd=http://demo.unified-streaming.com/video/tears-of-steel/tears-of-steel-wvtt.ism/.mpd

  1. If the bug is intermittent, give a rough frequency if possible

Bug happens every time

Observed behaviour

Chrome and Firefox display same behavior. "de" subtitles chosen by default, which are displayed double. Selecting a different language shows the subtitle correctly.

For Edge, shows first subtitles then shows no subtitles past 0:25.

It seems that the player loads both sidecar wvtt files as well as the fragmented wvtt and breaks initialization.

Related issue: https://github.com/Dash-Industry-Forum/dash.js/issues/2529 still apparent in 2.8.0 2 8 0-firefox

unifiedstreaming commented 6 years ago

Hi @nicosang, the subtitles bugfix #2691 seems to have resolved the issue. Text no longer appears double for Chrome and Firefox, and Edge now plays back the subtitles correctly. Thanks for the fix!