Fix disabling of catchup (leave playback rate alone)

difosfor commented 4 years ago

Environment

[x] The MPD passes the DASH-IF Conformance Tool on https://conformance.dashif.org/
[x] The stream has correct Access-Control-Allow-Origin headers (CORS)
[x] There are no network errors such as 404s in the browser console when trying to play the stream
[x] The issue observed is not mentioned on https://github.com/Dash-Industry-Forum/dash.js/wiki/FAQ
[x] The issue occurs in the latest reference client on http://reference.dashif.org/dash.js/ and not just on my page
Link to playable MPD file: Any low latency stream, e.g: https://akamaibroadcasteruseast.akamaized.net/cmaf/live/657078/akasource/out.mpd
Dash.js version: 3.0.0
Browser name/version: Any browser
OS name/version: Any OS

Steps to reproduce

Create MediaPlayer: const player = MediaPlayer().create()
Enable low latency and disable catchup: player.updateSettings({ streaming: { lowLatencyEnabled: true, liveCatchUpPlaybackRate: 0 } })
Initialize, e.g: player.initialize(media, sourceUrl, true)
Change playback rate, e.g: player.setPlaybackRate(1.1)

Observed behaviour

The playback rate is changed back to 1 even though catchup was disabled.

Console output

player.setPlaybackRate(1.1)
undefined
[24411][PlaybackController] Native video element event: ratechange:  1.1 
[24418][PlaybackController] Native video element event: ratechange:  1

Notes

This is a regression of my previous issue #2897. I've noted what I think to be the fix in a comment in there. I'm now creating this issue and will fork and try to fix it and then create a PR with that fix for your consideration.

difosfor commented 4 years ago

Created pull request: #3085

Brainiarc7 commented 4 years ago

This explains inexplicable stutters observed even with standard DASH manifests containing multiple adaptation sets, where the same variants packaged for HLS play smoothly with no issues.

EDIT: Stripped the linked issue I had stated.

epiclabsDASH commented 4 years ago

@Brainiarc7, I don't think those are related at all. Issue reported by @difosfor is about low latency management, not about streams with multiple adaptation sets or about smooth transitions across periods.

@difosfor, thanks for the fix!

Dash-Industry-Forum / dash.js