search

Dash-Industry-Forum / dash.js

A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.
http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html
Other
5.13k stars 1.68k forks source link

Missing ControlBar.js in DASH 4.2.0 #3877

Closed maral21 closed 2 years ago

maral21 commented 2 years ago
Environment
Steps to reproduce

1.npm install npm install dashjs@4.2.0

Observed behavior

We are installing dashjs with Node version 14.15.4 and we are having issues because we used the ControlBar.js reference from akamai When installing the version 4.2.0 of dashjs out application asks for this ControlBar.js references, the .js and .css files.

image

image

If we compare with version 3.2.0 which is the one that we had before:

image

There are a lof of things missing and the contrib folder has dissapeared.

Expected behavior

It would be expected that at least the contrib folder and src code is there

What have happened? We have read the migration notice from 3.0.0 and 4.0.0 and we have no detected this change

Was the ControlBar from akamai removed? Thanks in advance!

w

dsilhavy commented 2 years ago

You are right, as defined in the package.json we do include the following files in the npm package:

    "files": [
        "githook.js",
        "index.d.ts",
        "dist",
        "docs/jsdoc"
    ]

We can add the ControlBar to the package again.

maral21 commented 2 years ago

A lot of thanks for your answer

When this would be added, by 4.3.0? or before?

I am not familiar with the frequency of releasing process

dsilhavy commented 2 years ago

With the next release, not quite sure about the version number yet (either 4.2.2 or 4.3.0). Release will be before end of February

maral21 commented 2 years ago

A lot of thanks

dsilhavy commented 2 years ago

Added Akamai Controlbar to the package here: https://github.com/Dash-Industry-Forum/dash.js/commit/c70fe9f3a078cd1907091c4d0cef9fe11011c215