search

Dash-Industry-Forum / dash.js

A reference client implementation for the playback of MPEG DASH via Javascript and compliant browsers.
http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html
Other
5.16k stars 1.68k forks source link

CC cannot be turned on after it was turned off #837

Closed KozhinM closed 9 years ago

KozhinM commented 9 years ago

Repro steps:

  1. Start playing an mpd with fragmented text (see example below)
  2. Turn off the subtitles via CC menu ("captions off" item). Observe: CC is hidden.
  3. In the CC menu click any CC item to turn CC on again. Observe: CC is not shown

test mpd: http://rdmedia.bbc.co.uk/dash/ondemand/elephants_dream/1/client_manifest-all.mpd

The issue seems to be introduced by the following commit: 86b0d497301ae9c4e5d4f068b9368e0dcb9b21b0

TobbeMobiTV commented 9 years ago

I've found the issue. In the process, I also found out that XML-file based subtitles are not cleared when the video is paused and the subtitles are turned off, so I include that in the PR.