Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
24 stars 0 forks source link

DTS verbose logging - add more logs #1061

Open m-iwanicki opened 1 week ago

m-iwanicki commented 1 week ago

The problem you're addressing (if any)

When using verbose output some parts stop being verbose e.g.:

Preparing ...
+ '[' -z 1 ']'
+ '[' -n 1 ']'
+ /usr/sbin/dasharo-deploy install
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
Choose your board model:
  0. None below
  1: V540TN
  2: V560TN

Enter an option: 2

Gathering flash chip and chipset information...
Flash information: vendor="Programmer" name="Opaque flash chip"
Flash size: 32M
Getting platform specific GPG key... Done
Backing up BIOS firmware and store it locally...
Remember that firmware is also backed up in HCL report.
Checking for Open Source Embedded Controller firmware
Backing up EC firmware...
Saving backup to: /fw_backup.tar.gz
tar: Removing leading `/' from member names
Successfully backed up firmware locally at: /fw_backup.tar.gz

Please, select Dasharo firmware version to install
  b) Back to main menu

Enter an option: b

Returning to main menu...

It already failed me twice when it stopped being verbose when I needed it.

There is also a problem that some of the scripts log errors or whole output to file which won't be shown by set -x e.g.: https://github.com/Dasharo/dts-scripts/blob/0ddb920446628460ecc378dcde6cfeffcbc229e4/scripts/dasharo-deploy#L285 This is mainly problem when sending debug logs in https://github.com/Dasharo/dts-scripts/blob/0ddb920446628460ecc378dcde6cfeffcbc229e4/include/dts-functions.sh#L1650, maybe add ERR_LOG_FILE or maybe all log files (e.g. FLASHROM_LOG_FILE) to be sent too?

Describe the solution you'd like

No response

Where is the value to a user, and who might that user be?

No response

Describe alternatives you've considered

No response

Additional context

Verbose output is disabled for this part most likely because this line

+ /usr/sbin/dasharo-deploy install

It's called as a separate command

m-iwanicki commented 1 week ago

@PLangowski You might be interested