Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
25 stars 0 forks source link

Add more descriptive curl errors #1063

Open m-iwanicki opened 1 month ago

m-iwanicki commented 1 month ago

The problem you're addressing (if any)

This https://github.com/Dasharo/dts-scripts/blob/5ebb3d910764a4589c6473a577c822967b3b0d19/scripts/dasharo-deploy#L515 line doesn't check http response but assumes that credentials are wrong.

Same here: https://github.com/Dasharo/dts-scripts/blob/5ebb3d910764a4589c6473a577c822967b3b0d19/include/dts-subscription.sh#L64

Describe the solution you'd like

We should check if returned response is 404 or 401 here and in other places and print better error message depending on response

Where is the value to a user, and who might that user be?

Describe alternatives you've considered

No response

Additional context

No response