Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
25 stars 0 forks source link

Disabling vboot breaks compilation on MSI boards #1145

Open frantic-from-paranoiawf opened 3 days ago

frantic-from-paranoiawf commented 3 days ago

Component

Dasharo firmware

Device

MSI Pro Z790-P

Dasharo version

v0.9.2

Dasharo Tools Suite version

No response

Test case ID

No response

Brief summary

When disabling vboot in the coreboot config, Dasharo fails to compile a rom.

How reproducible

100%

How to reproduce

  1. Clone latest v0.9.2 tag
  2. Disable vboot inside .config
  3. Compile

Expected behavior

Rom successfully compiles without vboot, can be flashed and used.

Actual behavior

After running make -j32, an error gets returned, with the rom failing to build.

E: FMAP_SECTION_ROMHOLE_START not found in build/fmap_config.h
E: Got invalid line for key 'FMAP_SECTION_ROMHOLE_START'
E: FMAP_SECTION_ROMHOLE_SIZE not found in build/fmap_config.h
E: Got invalid line for key 'FMAP_SECTION_ROMHOLE_SIZE'
    WRITE      MSI ROMHOLE
E: Image is missing 'ROMHOLE' region
E: The image will be left unmodified.
make: *** [util/msi/Makefile.inc:35: build_complete] Error 1

Screenshots

No response

Additional context

I'm not running Docker, however, the dasharo branch compiles fine for me.

Solutions you've tried

No response