Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
23 stars 0 forks source link

CPU/platform thermal configuration #141

Open miczyg1 opened 2 years ago

miczyg1 commented 2 years ago

The problem you're addressing (if any) Dasharo firmware currently does not support any thermal configuration

Describe the solution you'd like Add a Dasharo setup menu to configure the thermal options.

Where is the value to a user, and who might that user be? Some users may want to customize throttling temperature or other settings.

Describe alternatives you've considered None

Additional context None

macpijan commented 2 weeks ago

The CPU throttling has been enabled and will be available in future NovaCustom relases: https://docs.dasharo.com/unified/novacustom/features/#cpu-throttling-threshold

@filipleple is it specific to laptops, or would for e.g. MSI too?

zirblazer commented 2 weeks ago

As far that I know it should apply to the MSI too. Alder Lake-S Integration Guide mentioned TjMaxOffset.

13.112.2.37 TjMaxOffset UINT8 OVERCLOCKING_PREMEM_CONFIG::TjMaxOffset Specified value here is clipped by pCode (125 - TjMax Offset) to support TjMax in the range of 62 to 115 deg Celsius. Default: 0 Hardware Defaults Range 10 to 63. 0 = No offset / Keep HW default.

For rather obvious reasons you do not want it to be above default (Which most likely is 100°C based on empirical evidence), but below that it should be possible to cap it at 62°C for whatever reason you want to. So it means that viable values should be between 25 (100°C) to 63 (62°C). I have no preference about whenever you want to expose it as some integer input field from 25 to 63 or prefer to be some kind of list with those predefined values to select from to keep users from putting Processor at risk. Most likely it will end like some list with individual target values already in Celsius.

filipleple commented 2 weeks ago

@macpijan it should be a quick mod to enable handling the option for MSI in coreboot, the edk2 part is platform-independent

miczyg1 commented 2 weeks ago

As far that I know it should apply to the MSI too. Alder Lake-S Integration Guide mentioned TjMaxOffset.

13.112.2.37 TjMaxOffset UINT8 OVERCLOCKING_PREMEM_CONFIG::TjMaxOffset Specified value here is clipped by pCode (125 - TjMax Offset) to support TjMax in the range of 62 to 115 deg Celsius. Default: 0 Hardware Defaults Range 10 to 63. 0 = No offset / Keep HW default.

For rather obvious reasons you do not want it to be above default (Which most likely is 100°C based on empirical evidence), but below that it should be possible to cap it at 62°C for whatever reason you want to. So it means that viable values should be between 25 (100°C) to 63 (62°C). I have no preference about whenever you want to expose it as some integer input field from 25 to 63 or prefer to be some kind of list with those predefined values to select from to keep users from putting Processor at risk. Most likely it will end like some list with individual target values already in Celsius.

This is not TJMaxOffset, but TccOffset