Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
25 stars 0 forks source link

No HDMI output in firmware #533

Open johanes2115 opened 1 year ago

johanes2115 commented 1 year ago

Device

Novacustom TGL

Dasharo version

v1.7.0

Affected component(s) or functionality

HDMI output

Brief summary

There is no HDMI output in firmware, which makes remote automatic validation not possible.

How reproducible

100%

How to reproduce

  1. Connect external HDMI output
  2. Power on the device

Expected behavior

HDMI output in firmware.

Actual behavior

No HDMI output in firmware.

Screenshots

No response

Additional context

No response

Solutions you've tried

No response

mkopec commented 1 year ago

AlderLake FSP has a LidStatus option that tells the GOP driver which screen to use. Looks like TigerLake FSP doesn't have it. Not sure what can be done here. Maybe have 2 VBTs in CBFS and switch between them depending on lid state? @miczyg1

miczyg1 commented 1 year ago

Unfixable. TGL FSP creates the GOPPolicy with GetPlatformLidStatus returning EFI_UNSUPPORTED. So unless you hack your own FSP and expose such option, this is not doable.

pietrushnic commented 1 year ago

@miczyg1 AFAIK, we should be able to do that. Another reason is to choose Dasharo.

miczyg1 commented 1 year ago

@miczyg1 AFAIK, we should be able to do that. Another reason is to choose Dasharo.

Yes, we can.

macpijan commented 1 year ago

There is no HDMI output in firmware, which makes remote automatic validation not possible.

Just to make it clear here, we can still run automated tests as we do not really rely on the display in actual tests. It is more convenient to use though, if we can remotely use the display, of course.

mkopec commented 1 year ago

If we really need this, we can just unplug the eDP cable, FSP will see it's missing and output to HDMI :^)

mkopec commented 11 months ago

@miczyg1 could we not just include the Intel GOP driver in UEFIPayload and run it with policy specified by UEFI instead of coreboot?

mkopec commented 10 months ago

If we really need this, we can just unplug the eDP cable, FSP will see it's missing and output to HDMI

Yeah, I needed KVM to debug issues with testing quicker, and just unplugged the eDP cable and I get FW on HDMI.