search

Dasharo / dasharo-issues

The Dasharo issue tracker
https://dasharo.com/
24 stars 0 forks source link

Logo customisation not working #904

Closed wessel-novacustom closed 2 months ago

wessel-novacustom commented 3 months ago

Component

Dasharo firmware, Dasharo Tools Suite

Device

NovaCustom V56 14th Gen

Dasharo version

v0.9.0-rc5

Dasharo Tools Suite version

v2.0.0-rc1

Brief summary

Changing the logo was not successful

How reproducible

100% reproducible.

How to reproduce

  1. Host the image BLANK.bmp on a local web server. This is an uncompressed fully black image. The command file BLANK.bmp returns: BLANK.bmp: PC bitmap, Windows 3.x format, 577 x 432 x 24, image size 748224, resolution 2835 x 2835 px/m, cbSize 748278, bits offset 54
  2. Disable flash protections in the UEFI firmware settings.
  3. Boot to the Dasharo Tools Suite (DTS) and drop to a shell.
  4. Execute the following lines:

flashrom -p internal -r ROM.BIN wget http://192.168.x.x/path/to/BLANK.bmp dcu ROM.BIN logo -l BLANK.bmp (command successful) flashrom -p internal --ifd -i bios -w ROM.BIN && systemctl poweroff

Expected behavior

The NovaCustom logo is replaced with the blank image.

Actual behavior

The NovaCustom logo is still the BIOS boot splash logo.

Screenshots

No response

Additional context

Is the file type supported and does it make sense to try another file type?

Solutions you've tried

No response

mkopec commented 3 months ago

I can see coreboot correctly loads a logo into CBMEM, but EDK2 doesn't apply it. Probably got lost during EDK2 rebase

SergiiDmytruk commented 3 months ago

Probably got lost during EDK2 rebase

They weren't marked as required for inclusion into rebased version. I thought that's because they are in upstream now, but doesn't look like it. @mkopec, should I add them or you're doing it already?

mkopec commented 3 months ago

@SergiiDmytruk I haven't started doing it yet, if you could help with that it would be great :)

SergiiDmytruk commented 3 months ago

I'll add them to the branch then.

SergiiDmytruk commented 3 months ago

Picking up https://github.com/Dasharo/edk2/pull/129/commits/43302b40dae80ac3ac651421d04b232cd85cb358 should fix this. Works for me in Q35.

wessel-novacustom commented 3 months ago

Picking up Dasharo/edk2@43302b4 should fix this. Works for me in Q35.

mkopec commented 3 months ago

Confirmed resolved by uprevving edk2 to https://github.com/Dasharo/edk2/pull/129/commits/43302b40dae80ac3ac651421d04b232cd85cb358

filipleple commented 2 months ago

I haven't managed to set a custom logo in 0.9.0-rc7 on V540TU either

wessel-novacustom commented 2 months ago

@mkopec It is not working yet for 0.9.0-rc7 on the V560TU.

wessel-novacustom commented 2 months ago

Solved with 0.9.0-rc10.

mkopec commented 2 months ago

@filipleple Could you confirm that the issue is fixed on rc10? It works on my end with a V560TU rc10

filipleple commented 2 months ago

@mkopec yes, after a quick consultation I can confirm this is resolved for V540TU as well :D