Tests fail due to missing packages

mkopec commented 7 months ago

Device

NovaCustom NS70MU

RTE version

n/a

Affected component(s) or functionality

Wi-Fi / BT tests

Brief summary

Wi-Fi / BT tests fail due to missing lspci package

How reproducible

100%

How to reproduce

install ubuntu 22.04
start running tests on a clean installation

Expected behavior

tests install all missing utils automatically

Actual behavior

tests fail because lspci is missing

Link to screenshots or logs

Additional context

No response

Solutions you've tried

don't depend on lspci?
take care of installing all utilities in suite setup. ethtool is also not installed OOTB, so warmboot tests using WoL fail.

mkopec commented 7 months ago

another one: fwts in SUSP005.002

macpijan commented 3 months ago

@JanPrusinowski So essentially you should look at the reported tests and make sure to install packages via Detect Or Install Package <pkg> keyword first, to make sure the package will be available in the system even on the fresh insall.

Example: https://github.com/Dasharo/open-source-firmware-validation/blob/main/dasharo-compatibility/usb-camera.robot#L36

You should check for all tests where lspci or lsusb or fwts is used, and fix the tests accordingly.

JanPrusinowski commented 3 months ago

PR availible: https://github.com/Dasharo/open-source-firmware-validation/pull/300

Dasharo / open-source-firmware-validation