Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
7 stars 1 forks source link

DTS tests fail on laptops (Boot Dasharo Tools Suite kwd fails) #196

Open mkopec opened 7 months ago

mkopec commented 7 months ago

Device

NovaCustom NS70MU

RTE version

n/a

Affected component(s) or functionality

Tests using DTS (for example LCM001.001)

Brief summary

Tests expect DTS console to appear on serial, but that's not possible on laptops due to how the EC console works.

How reproducible

100%

How to reproduce

Expected behavior

test work

Actual behavior

tests fail due to timeout, right after loading DTS via iPXE

Link to screenshots or logs

image

Additional context

I guess we could try to blindly enable the SSH server via PiKVM and then have tests use SSH in DTS instead of telnet, or figure out a better laptop serial console connection

Solutions you've tried

No response

macpijan commented 3 months ago

We do this, and it used to work on MSIs at least. How it was done: https://github.com/Dasharo/open-source-firmware-validation/issues/282#issuecomment-2104517338

There are recent problems reported by @m-iwanicki though.

m-iwanicki commented 3 months ago

If I understand this comment correctly it means that on serial we only have [keyboard] input and no [console] output?

It's that's true then after this comment there should be no reading from terminal until we connect via ssh but next keyword waits for menu to be seen.

# Wait for the menu to be loaded on serial
        Read From Terminal Until    Enter an option:

@mkopec Maybe mention in the description that it's "Boot Dasharo Tools Suite" keyword that fails? It'll be easier to find in issues when searching.

m-iwanicki commented 2 months ago

Should be fixed by https://github.com/Dasharo/open-source-firmware-validation/pull/317. Tested on msi (DTS003.001) to check if my changes didn't mess anything up. Didn't test on laptop as the one in the lab is not available.