Dasharo / open-source-firmware-validation

OSFV infrastructure with automated tests and scripts for managing test results
Apache License 2.0
6 stars 1 forks source link

Add `watchdog` test after kernel crash #215

Open Psotas opened 4 months ago

Psotas commented 4 months ago

The problem you're addressing (if any)

No watchdog option tests

Describe the solution you'd like

No response

Where is the value to a user, and who might that user be?

No response

Describe alternatives you've considered

No response

Additional context

No response

macpijan commented 4 months ago

Related ticket: https://github.com/Dasharo/dasharo-issues/issues/734

PLangowski commented 2 months ago

@macpijan could you provide a description of what should be done here?

artur-rs commented 2 months ago

@PLangowski issue linked by Maciej shows the entire test case with steps to introduce the new test. First, check and propose the best place for the new test, then implement and verify it.

During verification you can use firmware with and without the fix mentioned in the issue 734

PLangowski commented 2 months ago

Is there a binary with the fix that I can download or do I have to build it from source?

macpijan commented 2 months ago

Sometimes it is a matter of checking what's there and some issues might be fixed already. For watchdog, it seems we already have a test here: https://github.com/Dasharo/open-source-firmware-validation/blob/develop/dasharo-compatibility/watchdog.robot

PLangowski commented 2 months ago

@macpijan We don't have a test that verifies that the watchdog resets the machine after a kernel crash.

PLangowski commented 2 months ago

Unless it's the same case as in the second test

macpijan commented 2 months ago

Right, got misled by the issue name. Adding a test after kernel crash would make very much sense. Reopening.

macpijan commented 2 months ago

In terms of firmware, you should be able to get one from the CI in the linked PR.

PLangowski commented 2 months ago

Yes, I've been searching for the artifacts from the deployment, but I can't find any

EDIT: nvm, just found it. Thanks.